[ https://issues.apache.org/jira/browse/OPENNLP-1135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17656176#comment-17656176 ]
ASF GitHub Bot commented on OPENNLP-1135: ----------------------------------------- mawiesne commented on code in PR #485: URL: https://github.com/apache/opennlp/pull/485#discussion_r1064812250 ########## opennlp-tools/src/main/java/opennlp/tools/util/ext/ExtensionServiceKeys.java: ########## @@ -17,11 +17,11 @@ package opennlp.tools.util.ext; -public final class ExtensionServiceKeys { +public class ExtensionServiceKeys { Review Comment: @atarora Could you shortly elaborate why this class should not be `final` any more? > Remove support for OSGi > ----------------------- > > Key: OPENNLP-1135 > URL: https://issues.apache.org/jira/browse/OPENNLP-1135 > Project: OpenNLP > Issue Type: Wish > Reporter: Jörn Kottmann > Assignee: Atita Arora > Priority: Minor > > Remove the OSGi bundle support from the opennlp-tools jar. OSGi isn't used > widely and the ones who are using it know how to use opennlp-tools in an OSGi > environment anyway by applying some build tricks. -- This message was sent by Atlassian Jira (v8.20.10#820010)