[
https://issues.apache.org/jira/browse/OPENNLP-1441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17675667#comment-17675667
]
ASF GitHub Bot commented on OPENNLP-1441:
-----------------------------------------
mawiesne opened a new pull request, #488:
URL: https://github.com/apache/opennlp/pull/488
Change
-
- reworks existing classes calling `String.replaceAll(..)` which might
impact performance; it internally compiles a regex Pattern instance which is
inefficient when used in iterations
- extracts regular expressions used method locally into pre-compiled
`Pattern` constants
Tasks
-
Note: see also:
https://medium.com/javarevisited/micro-optimizations-in-java-string-replaceall-c6d0edf2ef6
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically main)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
clean install at the root opennlp folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file in opennlp folder?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found in opennlp folder?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions for
build issues and submit an update to your PR as soon as possible.
> Check and possibly replace usage of String.replaceAll(...) in code-base
> -----------------------------------------------------------------------
>
> Key: OPENNLP-1441
> URL: https://issues.apache.org/jira/browse/OPENNLP-1441
> Project: OpenNLP
> Issue Type: Improvement
> Affects Versions: 2.1.0
> Reporter: Richard Zowalla
> Assignee: Martin Wiesner
> Priority: Major
> Fix For: 2.1.1
>
>
> String.replaceAll(...) is known to have a severe performance impact, if used
> often.
> We should check the usage in OpenNLP and replace it, if needed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
