[ 
https://issues.apache.org/jira/browse/OPENNLP-1448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17692847#comment-17692847
 ] 

ASF GitHub Bot commented on OPENNLP-1448:
-----------------------------------------

rzo1 commented on code in PR #492:
URL: https://github.com/apache/opennlp/pull/492#discussion_r1116132672


##########
opennlp-tools/src/main/java/opennlp/tools/parser/Parse.java:
##########
@@ -319,32 +323,25 @@ public void insert(final Parse constituent) {
       int pn = parts.size();
       for (; pi < pn; pi++) {
         Parse subPart = parts.get(pi);
-        //System.err.println("Parse.insert:con="+constituent+" sp["+pi+"] 
"+subPart+" "+subPart.getType());

Review Comment:
   Maybe we should re-add these statements and replace them with `trace(...)`. 
If we ever need to debug it, we can switch to trace to see what happens. 





> Introduce SLF4J in OpenNLP
> --------------------------
>
>                 Key: OPENNLP-1448
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-1448
>             Project: OpenNLP
>          Issue Type: Sub-task
>            Reporter: Richard Zowalla
>            Assignee: Richard Zowalla
>            Priority: Major
>
> This will be the first step regarding OPENNLP-1447.
> Goal is to replace System.err / System.out calls with logger output, which is 
> configurable.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to