[ https://issues.apache.org/jira/browse/OPENNLP-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17724563#comment-17724563 ]
ASF GitHub Bot commented on OPENNLP-1495: ----------------------------------------- jzonthemtn merged PR #534: URL: https://github.com/apache/opennlp/pull/534 > Reduce code duplication in opennlp.tools.ml package > --------------------------------------------------- > > Key: OPENNLP-1495 > URL: https://issues.apache.org/jira/browse/OPENNLP-1495 > Project: OpenNLP > Issue Type: Improvement > Components: Build, Packaging and Test, Machine Learning > Affects Versions: 2.2.0 > Reporter: Martin Wiesner > Assignee: Martin Wiesner > Priority: Minor > Fix For: 2.2.1 > > > Several classes in the _opennlp.tools.ml_ package which inherit from > _AbstractModelWriter_ suffer from code duplication, e.g. > {_}PerceptronModelWriter{_}, {_}GISModelWriter{_}, and _NaiveBayesModelWriter_ > Aims: > * Code duplication should & can be cleared from that part of the code base. > * Moreover, some of the the related tests classes can be (a) simplified, (b) > improved for reduced execution time and (c) better readability. -- This message was sent by Atlassian Jira (v8.20.10#820010)