[ https://issues.apache.org/jira/browse/OPENNLP-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17733922#comment-17733922 ]
ASF GitHub Bot commented on OPENNLP-1501: ----------------------------------------- rzo1 commented on PR #540: URL: https://github.com/apache/opennlp/pull/540#issuecomment-1596181985 Yup. It is a breaking API change in its current form. If we want to retain compatibility, we could re-add the Getters and mark them with `@Deprecated(forRemoval=true)`, so ppl can adjust before we break them. > Make use of Records and Pattern Matching for instanceof > ------------------------------------------------------- > > Key: OPENNLP-1501 > URL: https://issues.apache.org/jira/browse/OPENNLP-1501 > Project: OpenNLP > Issue Type: Improvement > Reporter: Martin Wiesner > Assignee: Martin Wiesner > Priority: Minor > > With the recent move to Java 17 (see: OpenNLP-1496), we can now modernize > some classes to reduce boilerplate code. > Aims: > * Make use of Java records, see: [https://openjdk.org/jeps/395] > * Make use of Pattern Matching for instanceof, see: > [https://openjdk.org/jeps/394] -- This message was sent by Atlassian Jira (v8.20.10#820010)