[ https://issues.apache.org/jira/browse/OPENNLP-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774496#comment-17774496 ]
ASF GitHub Bot commented on OPENNLP-1515: ----------------------------------------- jzonthemtn opened a new pull request, #551: URL: https://github.com/apache/opennlp/pull/551 Thank you for contributing to Apache OpenNLP. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [X] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [X] Has your PR been rebased against the latest commit within the target branch (typically main)? - [X] Is your initial contribution a single, squashed commit? ### For code changes: - [X] Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible. > Default to onnxruntime instead of onnxruntime-gpu > ------------------------------------------------- > > Key: OPENNLP-1515 > URL: https://issues.apache.org/jira/browse/OPENNLP-1515 > Project: OpenNLP > Issue Type: Task > Components: Deep Learning > Reporter: Jeff Zemerick > Priority: Major > > The onnxruntime-gpu dependency is currently being included by opennlp-dl. > <dependency> > <groupId>com.microsoft.onnxruntime</groupId> > <!-- This dependency supports CPU and GPU --> > <artifactId>onnxruntime_gpu</artifactId> > <version>${onnxruntime.version}</version> > </dependency> > The problem is, GPU support is only on Linux and Windows and not OSX. I think > it would be best to use the onnxruntime dependency instead. > But we need to make OpenNLP able to use GPU easily. -- This message was sent by Atlassian Jira (v8.20.10#820010)