[ https://issues.apache.org/jira/browse/OPENNLP-1479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794542#comment-17794542 ]
ASF GitHub Bot commented on OPENNLP-1479: ----------------------------------------- mawiesne commented on PR #559: URL: https://github.com/apache/opennlp/pull/559#issuecomment-1846627276 > Do you want me to extract the common code into a helper method? @l-ma Yes, that would be preferable. Reusing the very same code is a good thing. If you can refactor existing test code, as mentioned, which fits the scope of the issue, feel free to apply refactoring and extract it to helper methods. But: don't over-engineer things. It's always okay to open a new Jira to allow focus on other topics / parts of the code. Thx again. > Write better tests for pattern verification (tokenizers) > -------------------------------------------------------- > > Key: OPENNLP-1479 > URL: https://issues.apache.org/jira/browse/OPENNLP-1479 > Project: OpenNLP > Issue Type: Improvement > Components: Tokenizer > Affects Versions: 2.1.1 > Reporter: Bruno P. Kinoshita > Assignee: Lara Marinov > Priority: Major > Fix For: 2.3.2 > > > From [https://github.com/apache/opennlp/pull/516#issuecomment-1455015772] > At the moment our tests verify that the tokenizer objects are created > correctly (i.e. tests getters and setters, constructor, etc.), without > verifying the actual behavior when used in conjunction with other classes > (factory, tokenizer, trainers, etc). > It would be best to test the patterns used in the factories for different > languages with some interesting sample data (maybe something from project > gutenberg, open source news sites, etc.). -- This message was sent by Atlassian Jira (v8.20.10#820010)