[ https://issues.apache.org/jira/browse/OPENNLP-1479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17795265#comment-17795265 ]
ASF GitHub Bot commented on OPENNLP-1479: ----------------------------------------- kinow opened a new pull request, #563: URL: https://github.com/apache/opennlp/pull/563 Fixing accent in the Catalan example, thanks to @franra9 - https://github.com/apache/opennlp/pull/559#discussion_r1422019479. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically main)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder? - [x] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible. > Write better tests for pattern verification (tokenizers) > -------------------------------------------------------- > > Key: OPENNLP-1479 > URL: https://issues.apache.org/jira/browse/OPENNLP-1479 > Project: OpenNLP > Issue Type: Improvement > Components: Tokenizer > Affects Versions: 2.1.1 > Reporter: Bruno P. Kinoshita > Assignee: Lara Marinov > Priority: Major > Fix For: 2.3.2 > > > From [https://github.com/apache/opennlp/pull/516#issuecomment-1455015772] > At the moment our tests verify that the tokenizer objects are created > correctly (i.e. tests getters and setters, constructor, etc.), without > verifying the actual behavior when used in conjunction with other classes > (factory, tokenizer, trainers, etc). > It would be best to test the patterns used in the factories for different > languages with some interesting sample data (maybe something from project > gutenberg, open source news sites, etc.). -- This message was sent by Atlassian Jira (v8.20.10#820010)