[
https://issues.apache.org/jira/browse/OPENNLP-1530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798286#comment-17798286
]
ASF GitHub Bot commented on OPENNLP-1530:
-----------------------------------------
mawiesne opened a new pull request, #569:
URL: https://github.com/apache/opennlp/pull/569
Change
-
- adds `abb_IT.xml` to opennlp-tools/lang as provided by Gabriele Vaccari
via [OPENNLP-1163](https://issues.apache.org/jira/browse/OPENNLP-1163)
- adds new test cases for the IT localization
- adjusts and enhances existing test cases with Italian examples from
OPENNLP-1163
Tasks
-
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically main)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
clean install at the root opennlp folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file in opennlp folder?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found in opennlp folder?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions for
build issues and submit an update to your PR as soon as possible.
> Add Italian abbreviation dictionary
> -----------------------------------
>
> Key: OPENNLP-1530
> URL: https://issues.apache.org/jira/browse/OPENNLP-1530
> Project: OpenNLP
> Issue Type: Improvement
> Components: Sentence Detector, Tokenizer
> Affects Versions: 2.3.0, 2.3.1
> Reporter: Martin Wiesner
> Assignee: Martin Wiesner
> Priority: Minor
> Fix For: 2.3.2
>
> Original Estimate: 2h
> Time Spent: 1.25h
> Remaining Estimate: 0.75h
>
> Similar to the addition in OPENNLP-570 and OPENNLP-1526, an abbreviation
> dictionary for Italian sentence detection and tokenisation might be
> beneficial.
> Aims:
> - Create and add a new file {{abb_IT.xml}} to _opennlp-tools/lang/it_
> - Add basic set of test cases
> Use input found in:
> - OPENNLP-1163
> Potential follow-up for deeper investigation:
> - OPENNLP-1163
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
