[
https://issues.apache.org/jira/browse/OPENNLP-1446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800497#comment-17800497
]
ASF GitHub Bot commented on OPENNLP-1446:
-----------------------------------------
mawiesne opened a new pull request, #113:
URL: https://github.com/apache/opennlp-sandbox/pull/113
Change
-
- makes WSD evaluator tests run again
- renames existing other WSD tests from "Tester" to "Test" pattern
- restores resources as required originally by the WSD tests
- adds _semcor3.0_ files required for WSD (eval) tests
- fixes minor issues with tests in other modules, see OPENNLP-1532
- resolves _OPENNLP-1446_
Tasks
-
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically main)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via `mvn
clean install` at the root opennlp-sandbox folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](https://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file in opennlp-sandbox folder?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found in opennlp-sandbox folder?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions for
build issues and submit an update to your PR as soon as possible.
> Investigate why LeskEvaluatorTest and MFSEvaluatorTest fail while parsing
> 'EnglishLS.train'
> -------------------------------------------------------------------------------------------
>
> Key: OPENNLP-1446
> URL: https://issues.apache.org/jira/browse/OPENNLP-1446
> Project: OpenNLP
> Issue Type: Task
> Components: wsd
> Affects Versions: 2.1.0
> Reporter: Martin Wiesner
> Assignee: Martin Wiesner
> Priority: Minor
> Fix For: 2.3.2
>
>
> The _LeskEvaluatorTest_ & _MFSEvaluatorTest_ in the _opennlp-wsd_ sandbox
> component both fail parsing the 'EnglishLS.train' file. The data is kept
> original, downloaded from
> {{[https://web.eecs.umich.edu/~mihalcea/senseval/senseval3/data.html]}}
> h4. {{Aims:}}
> * Investigate what causes the xml parsing to fail
> * Fix it and make both existing tests pass
> * Optional: Improve the existing test code to be more strict.
> h4. Note:
> The test setup to reproduce this is on a branch and to be merged into the
> main branch.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
