[ 
https://issues.apache.org/jira/browse/OPENNLP-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801612#comment-17801612
 ] 

ASF GitHub Bot commented on OPENNLP-1531:
-----------------------------------------

kinow commented on PR #581:
URL: https://github.com/apache/opennlp/pull/581#issuecomment-1873484749

   > Nice PT text sample! Code-wise everything looks fine. 
   
   Easier after the code base has been cleaned up a few times, and especially 
having some recent examples like the Fr (and also have reviewed the previous 
PR's you added for other langs). Thanks!!!
   
   >`abb_PT.xml` is our largest abb dict so far, wow šŸš€!
   
   :tada: we have everything from the Brazilian Academia de Letras, plus `n.Ā°` 
that was missing, I believe :tada: 
   
   
   




> Add Portuguese abbreviation dictionary
> --------------------------------------
>
>                 Key: OPENNLP-1531
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-1531
>             Project: OpenNLP
>          Issue Type: Improvement
>    Affects Versions: 2.3.1
>            Reporter: Bruno P. Kinoshita
>            Priority: Minor
>
> Similar to the addition inĀ OPENNLP-570 and OPENNLP-1526, an abbreviation 
> dictionary for Italian sentence detection and tokenisation might be 
> beneficial.
> Aims:
>  - Create and add a new file {{abb_PT.xml}} to _opennlp-tools/lang/pt_
>  - Add basic set of test cases
> Other:
>  - Confirm if European/Brazilian/African/Creole Portuguese have the same 
> abbreviations or if we need different languages...



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to