[ https://issues.apache.org/jira/browse/OPENNLP-1542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803339#comment-17803339 ]
ASF GitHub Bot commented on OPENNLP-1542: ----------------------------------------- rzo1 opened a new pull request, #583: URL: https://github.com/apache/opennlp/pull/583 ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically main)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder? - [x] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Eval Run: https://ci-builds.apache.org/job/OpenNLP/job/eval-tests-configurable/17/ The current AD parser returns NULL tags in case they could not be parsed, for example: "=====P.vp" should be "=====P:vp" in the source data. The code in `ChunkSample` with `List.copyOf(....)` doesn't allow NULL values anymore leading to the NPE issue in the eval tests. This PR changes the related code to set an empty String instead of a NULL tag. I don't know, if `""`and `null` can be used as semantically equal here, but in any case it represents an unknown tag as a result from a failed parsing attempt. Eval accuracy will change a bit. See Slack thread for more details: https://the-asf.slack.com/archives/C03869UDYJG/p1704288164823829 > Investigate and fix failing PT chunker evaluation tests > ------------------------------------------------------- > > Key: OPENNLP-1542 > URL: https://issues.apache.org/jira/browse/OPENNLP-1542 > Project: OpenNLP > Issue Type: Task > Components: Chunker > Affects Versions: 2.3.1 > Reporter: Richard Zowalla > Assignee: Richard Zowalla > Priority: Major > > PT Chunker evaluation tests are failing due to code refactoring changes, cf. > [https://the-asf.slack.com/archives/C03869UDYJG/p1704288164823829] for > details. > Previous code allowed NULL values inside collections in ChunkerSample. New > code doesn'T, so the PT chunker eval tests fail with a NPE. -- This message was sent by Atlassian Jira (v8.20.10#820010)