[
https://issues.apache.org/jira/browse/OPENNLP-1589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864274#comment-17864274
]
ASF GitHub Bot commented on OPENNLP-1589:
-----------------------------------------
rzo1 commented on PR #635:
URL: https://github.com/apache/opennlp/pull/635#issuecomment-2218151801
Ok, Update by @mawiesne: the f-values from main are the correct ones. Tests
will output them, if cache is disabled.
Changing them (as done in my PR) is therefore an invalid operation.
Nevertheless, we need to investigate why == was used in the first place (and
not equals), and why this change only affects Dutch.
> Fix incorrect array check in CachedFeatureGenerator
> ---------------------------------------------------
>
> Key: OPENNLP-1589
> URL: https://issues.apache.org/jira/browse/OPENNLP-1589
> Project: OpenNLP
> Issue Type: Bug
> Components: Name Finder
> Affects Versions: 2.3.3
> Reporter: Martin Wiesner
> Assignee: Richard Zowalla
> Priority: Major
> Fix For: 2.4.0
>
>
> There is an invalid comparison for equality of two arrays in
> CachedFeatureGenerator#createFeatures(..) in line 58.
> Currently, many situations exists in which no improvements by the caching are
> achieved (as intended).
> This should be repaired and a test shall show the cache mechanism is working
> correctly.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
