[ https://issues.apache.org/jira/browse/OPENNLP-1594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865887#comment-17865887 ]
ASF GitHub Bot commented on OPENNLP-1594: ----------------------------------------- mawiesne commented on code in PR #158: URL: https://github.com/apache/opennlp-sandbox/pull/158#discussion_r1677369258 ########## summarizer/src/main/java/opennlp/summarization/Sentence.java: ########## @@ -113,38 +123,21 @@ public List<Sentence> getLinks() { return this.links; } - public double getWordWt() { + public double getWordWeight() { return wordWt; } - public void setWordWt(double wordWt) { + public void setWordWeight(double wordWt) { this.wordWt = wordWt; } public int getWordCnt() { Review Comment: Will adjust it with this PR. > Add stricter tests for Summarizer component > ------------------------------------------- > > Key: OPENNLP-1594 > URL: https://issues.apache.org/jira/browse/OPENNLP-1594 > Project: OpenNLP > Issue Type: Test > Affects Versions: 2.3.3 > Reporter: Martin Wiesner > Assignee: Martin Wiesner > Priority: Major > Fix For: 2.4.0 > > > While OPENNLP-1592 and OPENNLP-1593 raised test coverage for the summarizer > component, there are still some "dark spots" and probably inaccuracies in the > implementation of that component. More, stricter tests shall shed light on > the situation. > Aims: > * add further, stricter tests for the summarizer component > * clarify, at API level, the semantics and constraints of parameters > * better separate tests so that each test class has a clear responsibility > for its class under test > * improve / enhance the JavaDoc further -- This message was sent by Atlassian Jira (v8.20.10#820010)