[
https://issues.apache.org/jira/browse/OPENNLP-1599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17868694#comment-17868694
]
ASF GitHub Bot commented on OPENNLP-1599:
-----------------------------------------
jzonthemtn commented on code in PR #641:
URL: https://github.com/apache/opennlp/pull/641#discussion_r1691500911
##########
opennlp-tools-models/src/test/java/opennlp/tools/models/AbstractModelLoaderTest.java:
##########
@@ -33,6 +33,8 @@ public void testLoadOpenNLPModel() throws Exception {
model.getModelSHA256());
assertEquals("langdetect-183.bin", model.getModelName());
assertEquals("1.8.3", model.getModelVersion());
+ assertEquals("unknown"
+ /* "root" <- correct value after OpenNLP models 1.0.1 */,
model.getModelLanguage());
Review Comment:
This line will get changed after releasing the 1.0.1 models?
> Add "model.language" to opennlp-models
> --------------------------------------
>
> Key: OPENNLP-1599
> URL: https://issues.apache.org/jira/browse/OPENNLP-1599
> Project: OpenNLP
> Issue Type: Improvement
> Components: Models
> Reporter: Richard Zowalla
> Assignee: Richard Zowalla
> Priority: Major
> Fix For: 2.4.1
>
>
> I just integrated opennlp-models via Maven / Classpath in my application.
> While doing so, I noticed, that there is no simple way to get the language of
> the related model without loading it and checking the models name.
>
> Therefore, it would be neat to add a new property key "model.language" to
> retrieve the bootstraped language identifier to ease user consumption.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
