[
https://issues.apache.org/jira/browse/OPENNLP-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17898978#comment-17898978
]
ASF GitHub Bot commented on OPENNLP-1646:
-----------------------------------------
mawiesne opened a new pull request, #688:
URL: https://github.com/apache/opennlp/pull/688
Tasks
-
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically main)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
clean install at the root opennlp folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file in opennlp folder?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found in opennlp folder?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions for
build issues and submit an update to your PR as soon as possible.
> Remove compiler warnings in AbstractDL and inheriting classes
> -------------------------------------------------------------
>
> Key: OPENNLP-1646
> URL: https://issues.apache.org/jira/browse/OPENNLP-1646
> Project: OpenNLP
> Issue Type: Improvement
> Components: Deep Learning
> Affects Versions: 2.5.0
> Reporter: Martin Wiesner
> Assignee: Martin Wiesner
> Priority: Trivial
> Fix For: 2.5.1
>
>
> Starting with OPENNLP-1618, AbstractDL implements {{AutoClosable}}. However,
> the {{close}} method allows to throw any type inheriting from Exception.
> This, however, leads to a bunch of compiler warnings being issued:
> {{AbstractDL.java:[37,17] auto-closeable resource opennlp.dl.AbstractDL has a
> member method close() that could throw InterruptedException}}
> {{...}}
> during compilation, for all classes that inherit from or use {{AbstractDL}}.
> +The fix is simple+:
> Override the {{throws Exception}} declaration with more specific exceptions,
> for instance: {{throws OrtException, IllegalStateException}} that can be
> thrown in this case. Thus, {{InterruptedException}} is not declared /
> possible and *javac* is happy again.
> Let's cure this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
