[
https://issues.apache.org/jira/browse/OPENNLP-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17904464#comment-17904464
]
ASF GitHub Bot commented on OPENNLP-1664:
-----------------------------------------
mawiesne commented on code in PR #194:
URL: https://github.com/apache/opennlp-sandbox/pull/194#discussion_r1877939096
##########
opennlp-wsd/src/main/java/opennlp/tools/disambiguator/AbstractWSDisambiguator.java:
##########
@@ -22,37 +22,41 @@
import java.security.InvalidParameterException;
import java.util.ArrayList;
import java.util.List;
+import java.util.regex.Pattern;
+
+import net.sf.extjwnl.JWNLException;
Review Comment:
Thanks for checking & feedback.
> Switch to pre-trained UD models in WSD component
> ------------------------------------------------
>
> Key: OPENNLP-1664
> URL: https://issues.apache.org/jira/browse/OPENNLP-1664
> Project: OpenNLP
> Issue Type: Task
> Components: wsd
> Reporter: Martin Wiesner
> Assignee: Martin Wiesner
> Priority: Major
> Fix For: 2.5.2
>
>
> Atm, the opennlp-wsd sandbox component uses old (v1.5) models for testing,
> contained as binary artifacts in the test resources directory.
> Aims:
> - Get rid of this dependency on old model files
> - Switch to new pre-trained UD models (via OPENNLP_DOWNLOAD_HOME), maven
> artifacts can be added in a separate issue
> - Make the existing tests and integration / evaluation tests pass with the UD
> based models
> - Modernize and tidy up some existing code structures in terms of API and
> efficiency
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
