[
https://issues.apache.org/jira/browse/OPENNLP-827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17906067#comment-17906067
]
ASF GitHub Bot commented on OPENNLP-827:
----------------------------------------
mawiesne opened a new pull request, #198:
URL: https://github.com/apache/opennlp-sandbox/pull/198
Change
-
- adds a ton of tests for most classes / methods in wsd component
- drops `OSCCWSDContextGenerator.java `as the impl was not working (well)
and it was simply _unused_ throughout the wsd component
- improves and fixes code along the path where useful / required
- improves JavaDoc (a bit) along the path
Code Coverage
-
<img width="930" alt="Bildschirmfoto 2024-12-16 um 15 17 01"
src="https://github.com/user-attachments/assets/5c615576-549b-41c8-93f0-08e9e675a7fa";
/>
Tasks
-
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically main)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via `mvn
clean install` at the root opennlp-sandbox folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](https://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file in opennlp-sandbox folder?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found in opennlp-sandbox folder?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions for
build issues and submit an update to your PR as soon as possible.
> Add more test cases for WSD component
> -------------------------------------
>
> Key: OPENNLP-827
> URL: https://issues.apache.org/jira/browse/OPENNLP-827
> Project: OpenNLP
> Issue Type: Test
> Components: wsd
> Reporter: Anthony Beylerian
> Assignee: Martin Wiesner
> Priority: Minor
> Fix For: 2.5.2
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
