[
https://issues.apache.org/jira/browse/OPENNLP-789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17907089#comment-17907089
]
ASF GitHub Bot commented on OPENNLP-789:
----------------------------------------
rzo1 commented on code in PR #200:
URL: https://github.com/apache/opennlp-sandbox/pull/200#discussion_r1892564469
##########
opennlp-wsd/src/main/java/opennlp/tools/disambiguator/WTDIMS.java:
##########
@@ -123,31 +123,31 @@ public String[] getSentence() {
return sentence;
}
- public void setSentence(String[] sentence) {
+ private void setSentence(String[] sentence) {
Review Comment:
IS this class a candidate for a record?
> Extend JavaDoc for WSD component
> --------------------------------
>
> Key: OPENNLP-789
> URL: https://issues.apache.org/jira/browse/OPENNLP-789
> Project: OpenNLP
> Issue Type: Improvement
> Components: wsd
> Reporter: Jörn Kottmann
> Assignee: Martin Wiesner
> Priority: Major
> Labels: wsd
> Fix For: 2.5.2
>
>
> The WSDisambiguator is the main interface for the wsd component. It should
> have much more javadocs explaining what it does and what wsd is.
> Additionally add at least short javadocs to each class and method in the
> disambiguator package. One sentence is the minimum here.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
