[ 
https://issues.apache.org/jira/browse/OPENNLP-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17907583#comment-17907583
 ] 

ASF GitHub Bot commented on OPENNLP-1623:
-----------------------------------------

rzo1 commented on code in PR #201:
URL: https://github.com/apache/opennlp-sandbox/pull/201#discussion_r1894615438


##########
opennlp-coref/src/test/resources/models/training/coref/muc/LDC2003T13.sgml:
##########
@@ -0,0 +1,72 @@
+<!--
+   Licensed to the Apache Software Foundation (ASF) under one
+   or more contributor license agreements.  See the NOTICE file
+   distributed with this work for additional information
+   regarding copyright ownership.  The ASF licenses this file
+   to you under the Apache License, Version 2.0 (the
+   "License"); you may not use this file except in compliance
+   with the License.  You may obtain a copy of the License at
+
+     http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing,
+   software distributed under the License is distributed on an
+   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+   KIND, either express or implied.  See the License for the
+   specific language governing permissions and limitations
+   under the License.    
+-->
+<!--
+Origin: https://catalog.ldc.upenn.edu/LDC2003T13

Review Comment:
   Looks like this is taken from: 
https://catalog.ldc.upenn.edu/desc/addenda/LDC2003T13.txt
   In this case, we cannot claim, that it is ASLv2 license (had the same thing 
in StormCrawler Incubator with external sources). It seems "[LDC User Agreement 
for 
Non-Members](https://catalog.ldc.upenn.edu/license/ldc-non-members-agreement.pdf)"
 applies as a license here which would be incompatible with ASLv2 (see 
commercial section of that PDF).





> Add more test cases for Coref component
> ---------------------------------------
>
>                 Key: OPENNLP-1623
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-1623
>             Project: OpenNLP
>          Issue Type: Test
>          Components: Coref
>            Reporter: Martin Wiesner
>            Assignee: Martin Wiesner
>            Priority: Minor
>             Fix For: 2.5.2
>
>
> As the title says. 
> Aims:
> * Raise test coverage
> * Improve JavaDoc further



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to