[
https://issues.apache.org/jira/browse/OPENNLP-1676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17912243#comment-17912243
]
ASF GitHub Bot commented on OPENNLP-1676:
-----------------------------------------
mawiesne opened a new pull request, #222:
URL: https://github.com/apache/opennlp-sandbox/pull/222
Change
-
- tightens the paramter requirements of `Disambiguator` interface
- tightens the paramter requirements of `FeaturesExtractor` class
- adjusts implementation in related classes
- adds required JUnit tests
- removes `AbstractWSDisambiguator#setParams` method, as it can be done via
a constructor allowing a final for this field
Tasks
-
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically main)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via `mvn
clean install` at the root opennlp-sandbox folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](https://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file in opennlp-sandbox folder?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found in opennlp-sandbox folder?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions for
build issues and submit an update to your PR as soon as possible.
> Add stricter argument validation in WSD component
> -------------------------------------------------
>
> Key: OPENNLP-1676
> URL: https://issues.apache.org/jira/browse/OPENNLP-1676
> Project: OpenNLP
> Issue Type: Improvement
> Components: wsd
> Affects Versions: 2.5.1
> Reporter: Martin Wiesner
> Assignee: Martin Wiesner
> Priority: Minor
> Fix For: 2.5.4
>
>
> During work on OPENNLP-789, we discussed that a stricter validation of
> (constructor or method) arguments should be conducted, see:
> * [https://github.com/apache/opennlp-sandbox/pull/200#discussion_r1892551223]
> * [https://github.com/apache/opennlp-sandbox/pull/200#discussion_r1892559517]
> This follow-up issue aims at improving the WSD API towards stricter checks.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
