[
https://issues.apache.org/jira/browse/OPENNLP-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17950545#comment-17950545
]
ASF GitHub Bot commented on OPENNLP-1729:
-----------------------------------------
mawiesne opened a new pull request, #279:
URL: https://github.com/apache/opennlp-sandbox/pull/279
Change
-
- relates to OPENNLP-1729 and switches the Sandbox components to use
SNAPSHOTS of OpenNLP core to benefit (and demonstrate) the new approach of
loading models via jar files (available in the classpath).
- adapts code in `WSDHelper` to use ClassPathModelProvider
- adapts code in `ParserChunker2MatcherProcessor` to use
ClassPathModelProvider
- adapts code in `NounPOSTagger` and `DefaultDocProcessor` to use
ClassPathModelProvider
Notes
-
- `DownloadUtil` is not gone, as there is now ParserChunker or Parser model
via Maven Artifacts
Tasks
-
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically main)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via `mvn
clean install` at the root opennlp-sandbox folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](https://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file in opennlp-sandbox folder?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found in opennlp-sandbox folder?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions for
build issues and submit an update to your PR as soon as possible.
> Provide easier loading of Models for given model lang and type
> ---------------------------------------------------------------
>
> Key: OPENNLP-1729
> URL: https://issues.apache.org/jira/browse/OPENNLP-1729
> Project: OpenNLP
> Issue Type: New Feature
> Components: Models
> Affects Versions: 2.5.4
> Reporter: Martin Wiesner
> Assignee: Martin Wiesner
> Priority: Minor
> Fix For: 2.5.5
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Currently, quite some glue code is required to load a model for a certain
> language code and type, that is, LemmatizerModel, TokenizerModel, etc.
> Consequently, for some users it seems easier - or more attractive - to stick
> with DownloadUtil's simple way of getting a model via the local user home
> ".bin" cache, avoiding a switch towards bundled OpenNLP model jars.
> Aims:
> * Provide a short path to getting a ready to use model instance from the
> classpath for a certain language.
> * Extract {{ModelType}} from {{DownloadUtil}} for re-use in scenarios such
> as this one.}}
> * Introduce a new methods in existing {{{}ClassPathModelLoader{}}}, such as:
> {{<T extends BaseModel> T load(Set<ClassPathModelEntry> modelsInClassPath,
> String lang, ModelType type, Class<T> modelType)}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
