[
https://issues.apache.org/jira/browse/OPENNLP-1941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Richard Zowalla updated OPENNLP-1941:
-------------------------------------
Fix Version/s: 2.5.13
> Source release omits leipzig/samples/.hidden test resource
> ----------------------------------------------------------
>
> Key: OPENNLP-1941
> URL: https://issues.apache.org/jira/browse/OPENNLP-1941
> Project: OpenNLP
> Issue Type: Improvement
> Components: Build, Packaging and Test
> Reporter: Richard Zowalla
> Priority: Major
> Fix For: 2.5.13, 3.0.0
>
>
> Found while verifying 3.0.0\-M6 RC1 \(non\-blocking\).
> Comparing the source release against the git tag {{opennlp\-3.0.0\-M6}}, the
> only difference apart from git\-related files \({{.asf.yaml}},
> {{.gitattributes}}, {{.github}}, {{.gitignore}}\) is the missing test
> resource:
> {{opennlp\-core/opennlp\-formats/src/test/resources/opennlp/tools/formats/leipzig/samples/.hidden}}
> It is most likely dropped by the source assembly's default excludes for
> dotfiles. The build and all tests from the source release still pass, so the
> test exercising hidden\-file handling in the Leipzig sample stream factory
> apparently does not detect the file being absent.
> Proposed fix \(either\):
> \* Explicitly include the file in the source assembly descriptor, or
> \* Create the hidden file in the test setup \(e.g. in a {{@TempDir}}\)
> instead of shipping it as a resource, and make the test assert that it is
> actually skipped.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
