[
https://issues.apache.org/jira/browse/OPENNLP-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18120441#comment-18120441
]
ASF GitHub Bot commented on OPENNLP-1989:
-----------------------------------------
krickert commented on PR #1321:
URL: https://github.com/apache/opennlp/pull/1321#issuecomment-5881987260
Changes pushed:
- `FileEventStream` uses the shared split to patch javadoc.
- `NumberFormatException` is wrapped in `IllegalArgumentException`, and a
negative value throws `IllegalArgumentException` in `RealValueFileEventStream`
too, with `@throws` updated. (matches our IAE rule on nulls)
- `parseEvent` Javadoc now describes the method’s contract. Removed the
whitespace mode discussion from both the Javadoc and the manual.
- Shortened the manual to explain the format with one example and note the
outcome-only behavior change since 3.0.
- Moved the separator characters and format message into constants.
- Rewrote the PR description and removed the CI note and AI text.
Once #1278 is merged, I’ll update this PR and #1320 to use
`StringUtil.splitNonEmpty`.
> Regex removal (5b/10): Make event parsing deterministic and preserve feature
> identities
> ---------------------------------------------------------------------------------------
>
> Key: OPENNLP-1989
> URL: https://issues.apache.org/jira/browse/OPENNLP-1989
> Project: OpenNLP
> Issue Type: Improvement
> Reporter: Kristian Rickert
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Correct parsing in {{RealValueFileEventStream}}, {{RealBasicEventStream}},
> and {{SimpleEventStreamBuilder}} using explicit, documented delimiters
> independent of global tokenizer settings. Preserve Unicode characters within
> feature names, eliminate accidental empty features, and prevent outcome-only
> events from prematurely ending a stream. Report malformed records clearly and
> document the shared parsing API. Test exact outcomes, feature arrays, values,
> and continued reading after outcome-only events.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
