https://issues.apache.org/ooo/show_bug.cgi?id=121496

Pedro Giffuni <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |ACCEPTED
                 CC|                            |[email protected]
            Version|AOO 3.4.1                   |AOO400-dev
           Assignee|[email protected] |[email protected]
                   |g                           |

--- Comment #3 from Pedro Giffuni <[email protected]> ---
One style issue:

I think the macros you defined in
inc/pyuno/pyuno.hxx

would be better placed in
source/module/pyuno_impl.hxx

The reason is that I am trying to keep only compatibility for older python
versions in pyuno.hxx so non-standard macros should not be there. Putting them
inside the module reduces their scope.

I will see that things still build with Python 2.7.3 before committing. Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

Reply via email to