https://bz.apache.org/ooo/show_bug.cgi?id=126680

--- Comment #45 from Arrigo Marchiori <ard...@yahoo.it> ---
At a second thought, forcing all transliterations to follow the same rules may
not be the correct way to follow.

This bug shows that different parts of the code require different
transliteration rules. This can be confirmed by searching the code for
instantiations of the TransliterationWrapper class:

main/basic/source/runtime/methods.cxx
main/sc/source/core/data/global.cxx (2 occurrences)
main/sc/source/ui/docshell/impex.cxx
main/svl/inc/svl/ondemand.hxx (2 occurrences)
main/sw/source/core/bastyp/init.cxx
main/vcl/source/app/i18nhelp.cxx

Plus all the occurrences of OnDemandTransliterationWrapper::get().

It may make sense to have several Transliteration_caseignore instances, instead
of a "singleton". The Transliteration_caseignore class itself does not seem to
have been designed to be a singleton, IMHO.

The "singleton effect" is given by a "caching" inside method
TransliterationImpl::loadBody(): when multiple instances of the same class are
requested in a row, the first one is returned all the times.

This does not seem right IMHO. Removing that part allows each
TransliterationWrapper instance to have its own Transliteration_caseignore
instance.

-- 
You are receiving this mail because:
You are the assignee for the issue.

Reply via email to