https://issues.apache.org/ooo/show_bug.cgi?id=124065

--- Comment #8 from Andre <[email protected]> ---
(In reply to wujinlong from comment #6)
> Hi Andre,
> 
> - Documenting clearly in sc/in/document.hxx that the returned ScRangeName is
> volatile, ie can change at any time.

Checking that the calling code can handle this volatility is part of the
change, right?

> 
> I've added comments in document.hxx for this. And the patch is updated.
> 
> - Removing the SC_DLLPUBLIC specifier (if possible)
> This might be possible. My concerns are there may be some existing
> extensions of AOO that possibly called GetRangeName(). If we disable the DLL
> export, they might be broken. So I vote to preserve this in the code.
> 
> - Making it private (if possible)
> This seems not possible, because there are lots calls of GetRangeName() in
> other modules already.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

Reply via email to