chetanmeh commented on a change in pull request #4624: Combines active ack and
slot release when both are available.
URL: https://github.com/apache/openwhisk/pull/4624#discussion_r325990234
##########
File path:
core/invoker/src/main/scala/org/apache/openwhisk/core/invoker/InvokerReactive.scala
##########
@@ -54,9 +54,10 @@ object InvokerReactive extends InvokerProvider {
* @param Boolean is true iff the activation was a blocking request
* @param ControllerInstanceId the originating controller/loadbalancer id
* @param UUID is the UUID for the namespace owning the activation
- * @param Boolean is true this is resource free message and false if this is
a result forwarding message
+ * @param AcknowledegmentMessage the acknowledgement message to send
*/
- type ActiveAck = (TransactionId, WhiskActivation, Boolean,
ControllerInstanceId, UUID, Boolean) => Future[Any]
+ type ActiveAck =
Review comment:
Minor observation (or Rant!) - I always struggle in IDE whenever I want to
see impl of parameters which are specified as function signature instead of
trait (like in `ActiveAck`). Here things are bit simpler as we specify a `type`
alias which narrows down the search. Otherwise one need to check the whole call
hierarchy to understand where is. the actual impl
Having a trait enables easier checking of possible implementations to
understand the code flow. This is pre existing stuff ... but may be later we
refactor it and use a proper trait for such critical flows
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
