sven-lange-last commented on a change in pull request #4609: Add namespace
field to activation log
URL: https://github.com/apache/openwhisk/pull/4609#discussion_r326956331
##########
File path:
common/scala/src/main/scala/org/apache/openwhisk/core/database/ActivationFileStorage.scala
##########
@@ -84,9 +84,11 @@ class ActivationFileStorage(logFilePrefix: String,
private def transcribeLogs(activation: WhiskActivation, additionalFields:
Map[String, JsValue]) =
activation.logs.logs.map { log =>
- val line = JsObject(
- Map("type" -> "user_log".toJson) ++ Map("message" -> log.toJson) ++
Map(
- "activationId" -> activation.activationId.toJson) ++
additionalFields)
+ val line =
+ JsObject(
+ Map("type" -> "user_log".toJson) ++ Map("message" -> log.toJson) ++
Map(
+ "activationId" -> activation.activationId.toJson) ++ Map(
+ "namespace" -> activation.namespace.asString.toJson) ++
additionalFields)
Review comment:
Let's have a look at the code:
https://github.com/apache/openwhisk/blob/400a7915115576a363858788a6d080c389a80317/common/scala/src/main/scala/org/apache/openwhisk/core/database/ArtifactWithFileStorageActivationStore.scala#L55-L62
If you add the `namespace` field to the `additionalFields` map in line 58,
it will be persisted to logs via `activationFileStorage.activationToFile()` in
line 60.
The `additionalFields` map won't be considered when storing the activation
to the database (line 61).
Do you come to the same conclusion?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
