fribechi commented on a change in pull request #321:
URL: https://github.com/apache/openwhisk-catalog/pull/321#discussion_r636274075



##########
File path: packages/github/webhook.js
##########
@@ -52,7 +59,7 @@ function main(params) {
   var whiskCallbackUrl = urlHost.protocol + '//' + process.env.__OW_API_KEY + 
"@" + urlHost.host + '/api/v1/namespaces/' + encodeURIComponent(triggerName[1]) 
+ '/triggers/' + encodeURIComponent(triggerName[2]);
 
   // The URL to create the webhook on Github
-  var registrationEndpoint = 'https://api.github.com/repos/' + (organization ? 
organization : username) + '/' + repository + '/hooks';
+  var registrationEndpoint = 'https://'+ githubApi +'/repos/' + (organization 
? organization : username) + '/' + repository + '/hooks';

Review comment:
       I have inserted in the variable also the protocol




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to