upgle commented on code in PR #171:
URL: 
https://github.com/apache/openwhisk-runtime-go/pull/171#discussion_r935776213


##########
golang1.17/Dockerfile:
##########
@@ -38,7 +38,7 @@ RUN echo "deb http://deb.debian.org/debian buster-backports 
main contrib non-fre
      librdkafka-dev=0.11.6-1.1 &&\
     # Cleanup apt data, we do not need them later on.
     apt-get clean && rm -rf /var/lib/apt/lists/* &&\
-    go get -u github.com/go-delve/delve/cmd/dlv@v1.8.1 &&\
+    go install github.com/go-delve/delve/cmd/dlv@v1.8.1 &&\

Review Comment:
   This change is required to build a docker image 👍 
   
   ```
   go get: installing executables with 'go get' in module mode is deprecated.
           Use 'go install pkg@version' instead.
           For more information, see 
https://golang.org/doc/go-get-install-deprecation
           or run 'go help get' or 'go help install'.
   # github.com/rivo/uniseg
   pkg/mod/github.com/rivo/uniseg@v0.3.1/properties.go:130:6: missing function 
body
   pkg/mod/github.com/rivo/uniseg@v0.3.1/properties.go:130:20: syntax error: 
unexpected [, expecting (
   note: module requires Go 1.18
   The command '/bin/sh -c echo "deb http://deb.debian.org/debian 
buster-backports main contrib non-free"      >>/etc/apt/sources.list &&    echo 
'debconf debconf/frontend select Noninteractive' | debconf-set-selections &&    
apt-get update &&    apt-get upgrade -y --no-install-recommends &&    apt-get 
install -y apt-utils &&    apt-get install -y      curl      jq      git      
zip      vim &&    apt-get -y install      librdkafka1=0.11.6-1.1      
librdkafka++1=0.11.6-1.1 &&    apt-get -y install      
librdkafka-dev=0.11.6-1.1 &&    apt-get clean && rm -rf /var/lib/apt/lists/* && 
   go get -u github.com/go-delve/delve/cmd/dlv@v1.8.1 &&    mkdir /action' 
returned a non-zero code: 2
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to