ningyougang commented on code in PR #5313:
URL: https://github.com/apache/openwhisk/pull/5313#discussion_r949716834
##########
core/scheduler/src/main/scala/org/apache/openwhisk/core/scheduler/container/ContainerManager.scala:
##########
@@ -360,6 +338,87 @@ object ContainerManager {
*/
def rng(mod: Int): Int = ThreadLocalRandom.current().nextInt(mod)
+ // Partition messages that can use warmed containers.
+ // return: (list of messages that cannot use warmed containers, list of
messages that can take advantage of warmed containers)
+ protected[container] def filterWarmedCreations(warmedContainers: Set[String],
+ inProgressWarmedContainers:
TrieMap[String, String],
+ invokers: List[InvokerHealth],
+ msgs:
List[ContainerCreationMessage])(
+ implicit logging: Logging): (List[(ContainerCreationMessage, Option[Int],
Option[String])],
+ List[(ContainerCreationMessage, Option[Int],
Option[String])]) = {
+ val warmedApplied = msgs.map { msg =>
+ val warmedPrefix =
+ containerPrefix(ContainerKeys.warmedPrefix, msg.invocationNamespace,
msg.action, Some(msg.revision))
+ val container = warmedContainers
Review Comment:
container -> containers ? because it may has several values in Seq.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
