bdoyle0182 commented on code in PR #5326:
URL: https://github.com/apache/openwhisk/pull/5326#discussion_r976743330
##########
core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/v2/FunctionPullingContainerProxy.scala:
##########
@@ -732,7 +735,12 @@ class FunctionPullingContainerProxy(
data.action.fullyQualifiedName(false),
data.action.rev,
Some(data.clientProxy))
-
+ case Event(t: FailureMessage, data: WarmData) =>
+ logging.error(
+ this,
+ s"Failed to determine whether to keep or remove container on pause
timeout for ${data.container.containerId}, retrying. Caused by: $t")
+ startSingleTimer(DetermineKeepContainer.toString,
DetermineKeepContainer, 1.second)
Review Comment:
And if for whatever reason a new request comes in and it can't unpause the
container because the container is now broken for whatever reason, the
activation will get rescheduled so there would be latency for that case which
is already possible on any broken paused container but it's not any additional
latency from the 1 second retry and the failure case of unpausing will be
graceful now to correctly delete the broken container in all cases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
