bdoyle0182 commented on code in PR #5386:
URL: https://github.com/apache/openwhisk/pull/5386#discussion_r1128280547
##########
core/scheduler/src/main/scala/org/apache/openwhisk/core/scheduler/queue/MemoryQueue.scala:
##########
@@ -1201,6 +1207,13 @@ object MemoryQueue {
logging.info(
this,
s"[$invocationNamespace:$action:$stateName] some activations are stale
msg: ${queue.head.msg.activationId}.")
+ val currentTime = Instant.now.toEpochMilli
+ if (currentTime - lastActivationExecutedTime.get() > maxRetentionMs) {
+ MetricEmitter.emitGaugeMetric(
+ LoggingMarkers
+ .SCHEDULER_QUEUE_NOT_PROCESSING(invocationNamespace,
action.asString, action.toStringWithoutVersion),
Review Comment:
Okay I added an additional check that the time since last activation
executed must also be greater than the action timeout since I think that's a
fair case if the system is configured to support long running activations, you
may still not want the queue retention time to also be that high
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
