style95 commented on code in PR #233:
URL: 
https://github.com/apache/openwhisk-runtime-nodejs/pull/233#discussion_r1132230912


##########
core/nodejsActionBase/runner.js:
##########
@@ -46,6 +46,17 @@ function initializeActionHandler(message) {
                     return Promise.reject('Zipped actions must contain either 
package.json or index.js at the root.');
                 }
 
+                // install npm modules during init if source code zip doesn´t 
containt them

Review Comment:
   This is nice!
   I want to let this in but unsure if there would be no side effect.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to