style95 commented on code in PR #5435:
URL: https://github.com/apache/openwhisk/pull/5435#discussion_r1295279044


##########
core/invoker/src/main/scala/org/apache/openwhisk/core/invoker/Invoker.scala:
##########
@@ -186,7 +188,8 @@ object Invoker {
 
       // --uniqueName is defined with a valid value, id is empty, assign an id 
via zookeeper
       case CmdLineArgs(Some(unique), None, _, overwriteId) =>
-        if (config.zookeeperHosts.startsWith(":") || 
config.zookeeperHosts.endsWith(":")) {
+        if (config.zookeeperHosts.startsWith(":") || 
config.zookeeperHosts.endsWith(":") ||
+            config.zookeeperHosts.equals("")) {

Review Comment:
   It will make sure zookeeper hosts are configured when the ID assignor is 
used.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to