[GitHub] [openwhisk] style95 commented on a diff in pull request #5443: Add optional cpu limit to spawned action containers

[via GitHub]

style95 commented on code in PR #5443:
URL: https://github.com/apache/openwhisk/pull/5443#discussion_r1340751065


##########
ansible/roles/invoker/tasks/deploy.yml:
##########
@@ -258,6 +258,7 @@
       "CONFIG_whisk_containerFactory_containerArgs_network": "{{ 
invoker_container_network_name | default('bridge') }}"
       "INVOKER_CONTAINER_POLICY": "{{ invoker_container_policy_name | 
default()}}"
       "CONFIG_whisk_containerPool_userMemory": "{{ 
hostvars[groups['invokers'][invoker_index | int]].user_memory | 
default(invoker.userMemory) }}"
+      "CONFIG_whisk_containerPool_userCpus": "{{ invoker.userCpus | default() 
}}"

Review Comment:
   I could deploy this branch w/ and w/o this configuration using ansible.
   I confirmed that NanoCpus is properly configured in containers according to 
this config.
   
   ```json
   ...
               "CpuShares": 25,
               "Memory": 268435456,
               "NanoCpus": 0,
   ...
   ```
   
   ```json
   ...
               "CpuShares": 25,
               "Memory": 268435456,
               "NanoCpus": 150000000,
   ...
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org