bjustin-ibm commented on issue #1: Update source files with ASF Licenses; Add ASF badge to README. URL: https://github.com/apache/incubator-openwhisk-sample-matos/pull/1#issuecomment-314769188 As stated in other repos, I am all for having coding standards to bring some agreed-upon uniformity to our various code bases. On top of that, these specific changes do seem very reasonable to me. However... I don't like the idea of rationalizing this kind of massive change by saying that we have a tool that we can't or won't customize. I also don't like that there doesn't seem to be a formalized way for the developer to know exactly what the scancode tool expects, and/or to have a development tool that automatically ensures that changes that cause scancode violations don't appear in the very next commit. Perhaps scancode is or will be integrated into Travis, but I really don't think that it is reasonable to have a process where I commit, push, create a PR, and wait for Travis only to find out I have to _manually_ reformat my code. As for whether or not this particular PR should be merged, I think @glikson should probably chime in to make that decision. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
With regards, Apache Git Services
