rabbah commented on a change in pull request #2547: CLI Experimental api removal
URL: 
https://github.com/apache/incubator-openwhisk/pull/2547#discussion_r131179005
 
 

 ##########
 File path: tests/src/test/scala/whisk/core/cli/test/WskConfigTests.scala
 ##########
 @@ -149,9 +149,7 @@ class WskConfigTests
                 // Send request to https://<apihost>/api/v1/namespaces, wsk 
client passes client certificate to nginx, nginx will
                 // verify it by client ca's openwhisk-client-ca-cert.pem
                 val stdout = wsk.cli(Seq("property", "set", "-i", "--apihost", 
wskprops.apihost, "--auth", wskprops.authKey,
-                    "--cert", wskprops.cert, "--key", wskprops.key, 
"--namespace", namespace), env = env).stdout
 
 Review comment:
   WskProps is the class to retain - you should merge v2 into it. Not the other 
way around.
   Please restore cert and key.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to