bjustin-ibm commented on a change in pull request #199: Return Requested Accept 
Type on Trigger Delete
URL: 
https://github.com/apache/incubator-openwhisk-package-kafka/pull/199#discussion_r131247258
 
 

 ##########
 File path: action/kafkaFeedWeb.js
 ##########
 @@ -70,7 +70,14 @@ function main(params) {
                     db = new Database(params.DB_URL, params.DB_NAME);
                     return db.deleteTrigger(params.triggerName);
                 })
-                .then(resolve)
+                .then(() => {
+                    console.log('successfully deleted the trigger');
+                    resolve({
+                        statusCode: 200,
+                        headers: {'Content-Type': 'text/plain'},
+                        body: "deleted trigger"
+                    });
+                })
                 .catch(reject);
 
 Review comment:
   hmmm... shouldn't `reject` do the same?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to