markusthoemmes commented on a change in pull request #2584: SPI for Loadbalancer
URL:
https://github.com/apache/incubator-openwhisk/pull/2584#discussion_r132404790
##########
File path:
common/scala/src/main/scala/whisk/core/database/CouchDbRestStore.scala
##########
@@ -52,7 +52,8 @@ class CouchDbRestStore[DocumentAbstraction <:
DocumentSerializer](
dbPort: Int,
dbUsername: String,
dbPassword: String,
- dbName: String)(implicit system: ActorSystem, val logging: Logging,
jsonFormat: RootJsonFormat[DocumentAbstraction])
+ dbName: String,
+ cleanup:(String)=>Unit)(implicit system: ActorSystem, val logging:
Logging, jsonFormat: RootJsonFormat[DocumentAbstraction])
Review comment:
Why do you need to pass the `dbName` in? When you open the client you
automatically have it at hand.
`shutdown: => Unit` should suffice (note the whitespace please)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
