markusthoemmes commented on a change in pull request #2677: Add blocking
indicator for activation request.
URL:
https://github.com/apache/incubator-openwhisk/pull/2677#discussion_r136259460
##########
File path: common/scala/src/main/scala/whisk/core/entity/WhiskActivation.scala
##########
@@ -90,6 +90,7 @@ case class WhiskActivation(
}
}
+ def withoutLogsOrResponse = copy(response = ActivationResponse.success(),
logs = ActivationLogs()).revision[WhiskActivation](rev)
Review comment:
Falling back to a success always breaks the health-protocol doesn't it? We
can safely drop the user's response stuff, but we need to send the correct
statuscode I think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
