rabbah commented on a change in pull request #2683: Fix Binary Content-Type Responses for Web Actions URL: https://github.com/apache/incubator-openwhisk/pull/2683#discussion_r136469938
########## File path: tests/src/test/scala/whisk/core/controller/test/WebActionsApiTests.scala ########## @@ -811,6 +812,31 @@ trait WebActionsApiTests extends ControllerTestCommon with BeforeAndAfterEach wi } } + it should s"handle http web action with base64 encoded binary response (auth? ${creds.isDefined})" in { + implicit val tid = transid() + val png = "iVBORw0KGgoAAAANSUhEUgAAAAoAAAAGCAYAAAD68A/GAAAA/klEQVQYGWNgAAEHBxaG//+ZQMyyn581Pfas+cRQnf1LfF" + + "Ljf+62smUgcUbt0FA2Zh7drf/ffMy9vLn3RurrW9e5hCU11i2azfD4zu1/DHz8TAy/foUxsXBrFzHzC7r8+M9S1vn1qxQT07dDjL" + + "9fdemrqKxlYGT6z8AIMo6hgeUfA0PUvy9fGFh5GWK3z7vNxSWt++jX99+8SoyiGQwsW38w8PJEM7x5v5SJ8f+/xv8MDAzffv9hev" + + "fkWjiXBGMpMx+j2awovjcMjFztDO8+7GF49LkbZDCDeXLTWnZO7qDfn1/+5jbw/8pjYWS4wZLztXnuEuYTk2M+MzIw/AcA36Vewa" + + "D6fzsAAAAASUVORK5CYII=" + val expectedEntity = HttpEntity(ContentType(MediaTypes.`image/png`), Base64.getDecoder().decode(png)) + + Seq(s"$systemId/proxy/export_c.http"). + foreach { path => + allowedMethods.take(1).foreach { m => Review comment: Remove take 1. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services