dubeejw commented on a change in pull request #2855: Cache database attachments
URL:
https://github.com/apache/incubator-openwhisk/pull/2855#discussion_r144642462
##########
File path:
common/scala/src/main/scala/whisk/core/database/DocumentFactory.scala
##########
@@ -245,26 +261,35 @@ trait DocumentFactory[W] extends
MultipleReadersSingleWriterCache[W, DocInfo] {
}
}
- def getAttachment[Wsuper >: W](db: ArtifactStore[Wsuper],
- doc: DocInfo,
- attachmentName: String,
- outputStream: OutputStream)(implicit transid:
TransactionId): Future[Unit] = {
+ def getAttachment[Wsuper >: W](
+ db: ArtifactStore[Wsuper],
+ entity: W,
+ doc: DocInfo,
+ attachmentName: String,
+ outputStream: OutputStream,
+ postProcess: Option[PostProcessEntity[W]] = None)(implicit transid:
TransactionId, mw: Manifest[W]): Future[W] = {
implicit val ec = db.executionContext
+ implicit val notifier: Option[CacheChangeNotification] = None
Review comment:
Cache invalidation callback should probably be assigned to the actual
callback here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
