cbickel commented on a change in pull request #2810: Add couchdb clustering
URL: 
https://github.com/apache/incubator-openwhisk/pull/2810#discussion_r153527393
 
 

 ##########
 File path: ansible/templates/whisk.properties.j2
 ##########
 @@ -94,6 +94,8 @@ db.whisk.activations={{ db.whisk.activations }}
 db.whisk.actions.ddoc={{ db.whisk.actions_ddoc }}
 db.whisk.activations.ddoc={{ db.whisk.activations_ddoc }}
 db.whisk.activations.filter.ddoc={{ db.whisk.activations_filter_ddoc }}
+db.hosts={{ groups["db"] | map('extract', hostvars, 'ansible_host') | list | 
join(",") }}
 
 Review comment:
   what about renaming this value to `db.hostsList` as well? In the following 
code you always use dbHostsList.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to