dubeejw commented on a change in pull request #2847: Treat action code as
attachments for created/updated actions
URL:
https://github.com/apache/incubator-openwhisk/pull/2847#discussion_r144146877
##########
File path: common/scala/src/main/scala/whisk/core/entity/Exec.scala
##########
@@ -241,21 +241,33 @@ protected[core] object Exec extends ArgNormalizer[Exec]
with DefaultJsonProtocol
manifest.attached
.map { a =>
- val jar: Attachment[String] = {
- // java actions once stored the attachment in "jar" instead of
"code"
- obj.fields.get("code").orElse(obj.fields.get("jar"))
+ // java actions once stored the attachment in "jar" instead of
"code"
+ val code = obj.fields.get("code").orElse(obj.fields.get("jar"))
+
+ val binary: Boolean = code match {
+ case Some(JsString(c)) => isBinaryCode(c)
+ case _ =>
+ obj.fields.get("binary") match {
+ case Some(JsBoolean(b)) => b
+ case _ => false
Review comment:
Should probably error here since code and binary property is not defined.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
