cbickel commented on a change in pull request #3077: Enable ssl on the path between edge and controllers URL: https://github.com/apache/incubator-openwhisk/pull/3077#discussion_r167889282
########## File path: common/scala/src/main/scala/whisk/core/WhiskConfig.scala ########## @@ -98,6 +98,8 @@ class WhiskConfig(requiredProperties: Map[String, String], val controllerSeedNodes = this(WhiskConfig.controllerSeedNodes) val controllerLocalBookkeeping = getAsBoolean(WhiskConfig.controllerLocalBookkeeping, false) val controllerHighAvailability = getAsBoolean(WhiskConfig.controllerHighAvailability, false) + val controllerProtocol = this(WhiskConfig.controllerProtocol) + val controllerSSLEnabled = if (this.controllerProtocol == "https") true else false Review comment: As we need to go the internal way for triggers (long term), I think it's more valuable to use pureconfig here instead of the old whiskConfig. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
