tysonnorris commented on a change in pull request #3211: implement ContainerFactory.cpuShare to fix #3110 URL: https://github.com/apache/incubator-openwhisk/pull/3211#discussion_r170998685
########## File path: core/invoker/src/main/scala/whisk/core/containerpool/docker/DockerContainerFactory.scala ########## @@ -67,13 +70,13 @@ class DockerContainerFactory(config: WhiskConfig, image = image, userProvidedImage = userProvidedImage, memory = memory, - cpuShares = config.invokerCoreShare.toInt, + cpuShares = poolConfig.cpuShare, Review comment: on second thought - I'll go ahead and put this in, and if there is a simple way to update kube to respect the cpu limit, that can be added later; for now, kube will do nothing with that parameter. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services