markusthoemmes commented on a change in pull request #3369: Use pureconfig for
CouchDbRestStore
URL:
https://github.com/apache/incubator-openwhisk/pull/3369#discussion_r171985250
##########
File path: tests/src/test/scala/ha/ShootComponentsTests.scala
##########
@@ -67,13 +70,13 @@ class ShootComponentsTests
val controller0DockerHost = WhiskProperties.getBaseControllerHost()
val couchDB0DockerHost = WhiskProperties.getBaseDBHost()
- val dbProtocol = WhiskProperties.getProperty(WhiskConfig.dbProtocol)
+ val dbConfig = loadConfigOrThrow[CouchDbConfig](ConfigKeys.couchdb)
+ val dbProtocol = dbConfig.protocol
val dbHostsList = WhiskProperties.getDBHosts
- val dbPort = WhiskProperties.getProperty(WhiskConfig.dbPort)
- val dbUsername = WhiskProperties.getProperty(WhiskConfig.dbUsername)
- val dbPassword = WhiskProperties.getProperty(WhiskConfig.dbPassword)
- val dbPrefix = WhiskProperties.getProperty(WhiskConfig.dbPrefix)
- val dbWhiskAuth = WhiskProperties.getProperty(WhiskConfig.dbAuths)
+ val dbPort = dbConfig.port
+ val dbUsername = dbConfig.username
+ val dbPassword = dbConfig.password
+ val dbWhiskAuth = dbConfig.databases.get("WhiskAuth").get
Review comment:
Can this be `dbConfig.databaseFor[WhiskAuth]`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
