rabbah commented on a change in pull request #3388: Update require-whisk-auth
behavior to secure web action
URL:
https://github.com/apache/incubator-openwhisk/pull/3388#discussion_r172499869
##########
File path:
tests/src/test/scala/whisk/core/controller/test/WebActionsApiTests.scala
##########
@@ -197,7 +200,9 @@ trait WebActionsApiBaseTests extends ControllerTestCommon
with BeforeAndAfterEac
annotations ++
Parameters("web-export", JsBoolean(true)) ++ {
if (requireAuthentication) {
- Parameters("require-whisk-auth", JsBoolean(true))
+ Parameters(
+ "require-whisk-auth",
Review comment:
we should probably start pulling all the annotations to an Annotations
singleton.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
